fix(OAuth2API): enable token exchange without token #10312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10312 +/- ##
===========================================
- Coverage 95.89% 0.00% -95.90%
===========================================
Files 44 18 -26
Lines 3634 3967 +333
Branches 111 18 -93
===========================================
- Hits 3485 0 -3485
- Misses 149 3967 +3818
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vladfrangu
approved these changes
Jun 2, 2024
kyranet
approved these changes
Jun 2, 2024
SpaceEEC
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged: Currently, requests made by the OAuth2API class require the
Authorizationheader by default. If no token is set on the underlying REST client, this produces an error:However, for requests such as exchanging an authorization code for a token or refreshing using a refresh token, an existing token isn't required by the Discord API and doesn't really make sense; if the client already has a valid token, there's no need to exchange a code for a new token. (See here for a simple StackBlitz reproduction.) This PR disables the
Authorizationheader for these requests.Status and versioning classification: